Add macOS arm64 binary #186
Open
+18
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansedivy
force-pushed
the
jansedivy-add-macos-arch64
branch
from
fa59719
to
51efb43
Compare
|
thanks for the PR. the reason we haven't done this yet is concern over the ever-growing size of this package... already 143MB before this change! my current thinking is that we should publish per-platform packages like or is it fine and we should just accept the nearly 200mb packages? :) |
|
Some ideas on how to reduce size:
(mentioning facebook/flow#8664 to link issues together) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I noticed facebook/flow has been publishing macOS arm64 binaries since February 17th based on this commit facebook/flow@0c8fcd9.
This PR adds macOS arm64 binary to the flow-bin export.