Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill child process on SIGTERM #89

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Kill child process on SIGTERM #89

wants to merge 1 commit into from

Conversation

mkscrg
Copy link

@mkscrg mkscrg commented Oct 21, 2017

This is a fix for #88.

Ad-hoc test:

$ node_modules/.bin/flow server src 2>/dev/null &
[1] 10541
$ kill -s SIGTERM 10541
$ ps ax | grep flow
10594 s002  S+     0:00.00 grep flow

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@mkscrg
Copy link
Author

mkscrg commented Oct 21, 2017

CLA signed.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@mkscrg
Copy link
Author

mkscrg commented Oct 25, 2017

Looks like the AppVeyor build is broken on all commits. Works on my machine! 😝

@mkscrg
Copy link
Author

mkscrg commented Nov 1, 2017

cc @gabelevi maybe? Thoughts?

@sartaj
Copy link

sartaj commented May 17, 2018

The AppVeyor failure doesn't seem to be related to this PR

make test
'make' is not recognized as an internal or external command,
operable program or batch file.
Command exited with code 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants