Skip to content
This repository has been archived by the owner on Oct 1, 2020. It is now read-only.

Fix file delimiter under Windows when using git bash #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix file delimiter under Windows when using git bash #53

wants to merge 1 commit into from

Conversation

abuseofnotation
Copy link

Windows uses '' for delimiters, so flow reports 'path/to/file' as 'path\to\file' (which becomes 'pathtofile') when using vim from git bash or other simulated unix env.

Not sure what is the case with gvim.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gabelevi
Copy link
Contributor

gabelevi commented Aug 8, 2017

Can't unix pathnames contain \? Won't this mess with those?

$ touch "foo\\bar.txt"
$ ls foo\\bar.txt 
foo\bar.txt

Of course, it's pretty clowny to have backslashes in directory or filenames, but I worry that this find/replace will break something.

Of course, filenames can also contain ", so the code already is pretty flawed :/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants