This repository has been archived by the owner on Oct 1, 2020. It is now read-only.
Add syntax highlighting for flow comment types #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Match comment type include and annotation region. - Allow FlowType syntax inside of these regions. - Highlight single colon to represent special meaning (kept verbosely in type annotation).
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
This commit adds support for flow annotations to statements as the
following:
```
function test() /*: $await<number> */ {}
```
Adding `f:/*::` skips comment continuations on new lines, when in a type annotation comment. This needs to be prepended onto the existing comments, to remain the behavior of javascript's block comments.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I made this PR to allow for "easier" readability of type definitions, when using the flotate/comment type syntax.
I'm up for discussions, whether this is ok or needs expanding of any sort.
Changes:
type annotation).
Note:
BufWritePostautocommand, that loads the flow syntax items. Reloading the file with:efixes this.formatoptions(thecpoportions of them, to be specific), that I wasn't able to store/restore when adding a new line.