Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle candiate groups and users user task activity #2859

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tinabandaloemruli
Copy link
Contributor

added validation for non supported types of candidates user and group
added variables for a limitation of candidateGroups and candidateUsers and per default no limit
added normalization of candidateGroups and candidateUsers as duplicate values are possible and also empty values see Tests

@tijsrademakers
Copy link
Contributor

Hi @tinabandaloemruli, adding a limit on the number of candidate users and groups means that the process execution will basically fail when the number of candidate users and groups is exceeded for a specific user task. I'm not seeing the general benefit of adding this to Flowable, and certainly not on an engine configuration level, which means it's for every user task that will be created in every process definition.

@tinabandaloemruli
Copy link
Contributor Author

Hi @tinabandaloemruli, adding a limit on the number of candidate users and groups means that the process execution will basically fail when the number of candidate users and groups is exceeded for a specific user task. I'm not seeing the general benefit of adding this to Flowable, and certainly not on an engine configuration level, which means it's for every user task that will be created in every process definition.

@tijsrademakers Yes but what would be the reason to have an unlimited possibility to add them? Couldn't cause an overload of database at some point? And what about users having a huge amount of processes and data?

@tijsrademakers
Copy link
Contributor

We don't want to impose limits for this. If there's a reason to limit this then it can be done with for example task listeners etc.

@tinabandaloemruli
Copy link
Contributor Author

We don't want to impose limits for this. If there's a reason to limit this then it can be done with for example task listeners etc.

@tijsrademakers I have removed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants