test: enable functional catalog tests #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enable catalog tests instead of skipping them since serverside is ready - Warm up the server for search and show by running a search or show that is allowed to fail. No warmup for install or upgrade is performed because it hasn't been timing out in CI. - Move the upgrade test from cli/tests to functional tests and hit the catalog for the actual upgrade operation. The installation for an old version is still performed using mock data. Use an actual response from the server for that data, except manually change version to `old_version`.
mkenigs
requested review from
nicklewis,
dcarley,
billlevine,
ysndr and
zmitchell
|
Passing functional tests run at https://github.com/flox/flox/actions/runs/9038043980/job/24838364578 |
ysndr
approved these changes
May 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
billlevine
approved these changes
May 19, 2024
Co-authored-by: billlevine <bill@floxdev.com>
billlevine
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
old_version.