Use http helper #136
Closed
Use http helper #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ref #48 |
ganmacs
force-pushed
the
use-http-helper
branch
from
f9795dc
to
e1285f4
Compare
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
ganmacs
force-pushed
the
use-http-helper
branch
from
e1285f4
to
08ecf64
Compare
cosmo0920
approved these changes
Feb 18, 2020
repeatedly
reviewed
Feb 18, 2020
lib/fluent/plugin/in_prometheus.rb
Outdated
| @@ -55,6 +50,8 @@ def configure(conf) | |||
| nil | |||
| end | |||
| @num_workers = sysconf && sysconf.workers ? sysconf.workers : 1 | |||
| @secure = @transport_config.protocol == :tls || (@ssl && @ssl['enable']) | |||
| require 'openssl' if @secure | |||
There was a problem hiding this comment.
Put it on top of module is better.
lib/fluent/plugin/in_prometheus.rb
Outdated
| end | ||
|
|
||
| def send_request_to_each_worker | ||
| bind == '0.0.0.0' ? '127.0.0.1' : @bind |
| context 'when extra_conf is used' do | ||
| let(:config) do | ||
| %[ | ||
| type prometheus |
| driver.run(timeout: 1) | ||
| end | ||
|
|
||
| context 'old parameter given' do |
There was a problem hiding this comment.
This text is very similar to parent text. What is the different point?
There was a problem hiding this comment.
changed descriptions 9edca6f
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
|
@repeatedly how about this? |
repeatedly
approved these changes
Feb 20, 2020
This was referenced Apr 15, 2020
Merged
|
done by #148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be merged after the release which includes fluent/fluentd#2787.