Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce tailwatcher argument #2832

Merged
merged 12 commits into from
Feb 25, 2020
Merged

Reduce tailwatcher argument #2832

merged 12 commits into from
Feb 25, 2020

Commits on Feb 20, 2020

  1. define timer triger out of TailWatcher 

    Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
    @ganmacs
    ganmacs committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    efa5d56 View commit details
    Browse the repository at this point in the history

  2. define stat watcher out 

    Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
    @ganmacs
    ganmacs committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    948617a View commit details
    Browse the repository at this point in the history

  3. Fix failed spec 

    Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
    @ganmacs
    ganmacs committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    b060307 View commit details
    Browse the repository at this point in the history

  4. line_buffer_timer_flusher should have the line_buffer 

    TailWatcher is not related to this

Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
    @ganmacs
    ganmacs committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    c8abc09 View commit details
    Browse the repository at this point in the history

  5. rotate_wait is just used for log 

    and this log is no need to be put here

Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
    @ganmacs
    ganmacs committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    fdf9d71 View commit details
    Browse the repository at this point in the history

  6. Define method io_handler 

    Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
    @ganmacs
    ganmacs committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    c80ca87 View commit details
    Browse the repository at this point in the history

  7. Pass argument explicitly 

    Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
    @ganmacs
    ganmacs committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    26ae11a View commit details
    Browse the repository at this point in the history

  8. no need line_buffer_timer_flusher= 

    Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
    @ganmacs
    ganmacs committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    0ede8e7 View commit details
    Browse the repository at this point in the history

  9. respect the original order 

    Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
    @ganmacs
    ganmacs committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    cc37027 View commit details
    Browse the repository at this point in the history

  10. Add log which forgot to be copy 

    Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
    @ganmacs
    ganmacs committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    9940869 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2020

  1. Remove meaningless comment 

    Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
    @ganmacs
    ganmacs committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    269ea68 View commit details
    Browse the repository at this point in the history

  2. combine lines 

    Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
    @ganmacs
    ganmacs committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    857d9cb View commit details
    Browse the repository at this point in the history