Flush buffer is invoked in line buffer #2843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganmacs
force-pushed
the
flush_buffer-is-invoked-in-line-buffer
branch
from
bb55289
to
09f3bd9
Compare
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
it's okay that the order of TailWatcher#close and @line_buffer_timer_flusher&.close changes. io_handler is already closed, so no more data come in. Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
ganmacs
force-pushed
the
flush_buffer-is-invoked-in-line-buffer
branch
from
1c95886
to
edffed4
Compare
This was referenced Oct 2, 2023
Merged
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
after #2837
What this PR does / why we need it:
Docs Changes:
no
Release Note:
no