Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix appveyor ci for round4 #2864

Merged
merged 4 commits into from
Mar 10, 2020
Merged

Fix appveyor ci for round4 #2864

merged 4 commits into from
Mar 10, 2020

Commits on Mar 9, 2020

  1. test: Fix expected position entries on Windows 

    Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
    @cosmo0920
    cosmo0920 committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    317026d View commit details
    Browse the repository at this point in the history

  2. test: Use correct error message on Windows 

    Winsock generates the different error message than Linux's.

Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
    @cosmo0920
    cosmo0920 committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    3088e49 View commit details
    Browse the repository at this point in the history

  3. test: Sort by tag instead of time 

    Because these test cases should handle same timestamp.
We should sort with another sortable key such as tag.

Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
    @cosmo0920
    cosmo0920 committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    53c6652 View commit details
    Browse the repository at this point in the history

  4. test: Use binmode for Tempfile 

    In Windows, writing 0 contained contents should be written as binmode.
Otherwise, it will cause corrupted contents.

Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
    @cosmo0920
    cosmo0920 committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    7560a48 View commit details
    Browse the repository at this point in the history