Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to launch fluentd from C:\Program Files\ #2920

Merged
merged 6 commits into from
Apr 10, 2020

Commits on Mar 30, 2020

  1. Allow to launch fluentd from C:\Program Files\

    On testing arguments in RUBYOPT, command line arguments aren't quoted so
    that it will fail if ruby command (which is passed as the first
    arugment) is placed under a directory which contains spaces.
    
    Use `spawn(program, *args)` instead of `spawn(command, options={})` to
    fix it.
    
    Signed-off-by: Takuro Ashie <ashie@clear-code.com>
    ashie committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    eba73d9 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2020

  1. Add a test for fluent#2915

    Signed-off-by: Takuro Ashie <ashie@clear-code.com>
    ashie committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    3f1008e View commit details
    Browse the repository at this point in the history
  2. Fix typo

    Signed-off-by: Takuro Ashie <ashie@clear-code.com>
    ashie committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    8ec8f3e View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2020

  1. test: Fix the assertion message of assert_log_match

    It shows a wrong message "matched correctly" on failed case and doesn't
    show actual log. In addition it shows only one unmached pattern even if
    multiple patterns match unexpectedly. It makes hard to debug.
    
    Signed-off-by: Takuro Ashie <ashie@clear-code.com>
    ashie committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    6dc3955 View commit details
    Browse the repository at this point in the history
  2. Fix an omitted test "-E option is set to RUBYOPT" on Windows

    On Windows "-rC:/path/to/bundler/setup" is already set to RUBYOPT so that
    following error is occurred when original RUBYOPT is discarded:
    
    C:/tools/ruby25/lib/ruby/2.5.0/rubygems.rb:289:in `find_spec_for_exe':
    can't find gem bundler (>= 0.a) with executable bundle (Gem::GemNotFoundException)
    	from C:/tools/ruby25/lib/ruby/2.5.0/rubygems.rb:308:in `activate_bin_path'
    	from C:/tools/ruby25/bin/bundle:23:in `<main>'
    
    Signed-off-by: Takuro Ashie <ashie@clear-code.com>
    ashie committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    2dd1d37 View commit details
    Browse the repository at this point in the history
  3. test: Show the correct reason for an omitted test

    Signed-off-by: Takuro Ashie <ashie@clear-code.com>
    ashie committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    5c129dd View commit details
    Browse the repository at this point in the history