Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress warning of verify_hostname #2936

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Suppress warning of verify_hostname #2936

merged 2 commits into from
Apr 7, 2020

Commits on Apr 6, 2020

  1. OpenSSL::SSL::SSLContext supports #verify_hostname= after Ruby 2.4 

    https://docs.ruby-lang.org/en/2.4.0/OpenSSL/SSL/SSLContext.html
And we support ruby 2.4 or later

2.3 doesn't support(https://docs.ruby-lang.org/en/2.3.0/OpenSSL/SSL/SSLContext.html)

Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
    @ganmacs
    ganmacs committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    cbf3d11 View commit details
    Browse the repository at this point in the history

  2. verify_hostname should be set false when it donsn't need 

    to suppress the warning.

```
warning: verify_hostname requires hostname to be set
```

Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
    @ganmacs
    ganmacs committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    f7e45c6 View commit details
    Browse the repository at this point in the history