Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: Fix calculation of timekey stats #3018

Merged
merged 2 commits into from
Aug 31, 2020
Merged

buffer: Fix calculation of timekey stats #3018

merged 2 commits into from
Aug 31, 2020

Commits on Jun 2, 2020

  1. buffer: Fix calculation of timekey stats 

    The current approach of using `add_timekey` and `del_timekey` to track
the count of chunks in each timekey doesn't work as intended - the
count is never decreased to zero because of complications in chunk
creation, as a result the `oldest_timekey` stat is almost never updated
after initial flush(es).

This commit provides a simple and not-so-timely alternative, to perform
recalculation in every flush cycle.

Signed-off-by: Ji-Ping Shen <ji-ping.shen@relexsolutions.com>
    @jiping-s
    jiping-s committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    562d9b0 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. buffer: Update test for change in timekey stats 

    Signed-off-by: Ji-Ping Shen <ji-ping.shen@relexsolutions.com>
    @jiping-s
    jiping-s committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    5e5e0c3 View commit details
    Browse the repository at this point in the history