Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make better use of freeze #3170

Merged
merged 1 commit into from Nov 16, 2020
Merged

Make better use of freeze #3170

merged 1 commit into from Nov 16, 2020

Conversation

repeatedly
Copy link
Member

Signed-off-by: Masahiro Nakagawa repeatedly@gmail.com

Which issue(s) this PR fixes:
Follow up: #3152

What this PR does / why we need it:

  • Add freeze to string parameter
  • Remove duplicated freeze

Docs Changes:
No need

Release Note:
Add this to Refactoring code

Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. 👍

@repeatedly repeatedly merged commit 5e036cf into master Nov 16, 2020
@repeatedly repeatedly deleted the better-freeze branch November 16, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants