Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle service_discovery type on fluent-plugin-config-formatter #3178

Merged
merged 4 commits into from
Nov 24, 2020
Merged

Handle service_discovery type on fluent-plugin-config-formatter #3178

merged 4 commits into from
Nov 24, 2020

Commits on Nov 23, 2020

  1. command: plugin: Handle non-abbrev form on sd in type argument 

    Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
    @cosmo0920
    cosmo0920 committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    5368397 View commit details
    Browse the repository at this point in the history

  2. command: Add more testcases for sd type plugin 

    Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
    @cosmo0920
    cosmo0920 committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    6ef70c8 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2020

  1. command: test: Prevent hash key collisions on arguments testcases 

    `hash[(argv + options).join(" ")] = argv + options + [type + "fake"]`
ignores type differences.

This line should be:

```ruby
hash["[#{type}] " + (argv + options).join(" ")] = argv + options + [type, "fake"]
```

Or something plugin type included key should be used here.

Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
    @cosmo0920
    cosmo0920 committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    a18820a View commit details
    Browse the repository at this point in the history

  2. command: test: Add fake storage plugin arguments test cases 

    Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
    @cosmo0920
    cosmo0920 committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    82944b2 View commit details
    Browse the repository at this point in the history