Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor path and inode arguments related code #3196

Merged
merged 9 commits into from
Dec 14, 2020
Merged

Refactor path and inode arguments related code #3196

merged 9 commits into from
Dec 14, 2020

Commits on Dec 10, 2020

  1. Use target_info instead of path_with_inode and path and ino separated… 

    … arguments

Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
    @cosmo0920
    cosmo0920 committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    37eb013 View commit details
    Browse the repository at this point in the history

  2. position_file: Use more general name for key name 

    This is because `@map` contains path/inode key and its value.

Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
    @cosmo0920
    cosmo0920 committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    1eed5ec View commit details
    Browse the repository at this point in the history

  3. in_tail: Create a variable to prevent calling twice 

    Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
    @cosmo0920
    cosmo0920 committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    e4abf58 View commit details
    Browse the repository at this point in the history

  4. Use #dup insetad of freshly created struct 

    Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
    @cosmo0920
    cosmo0920 committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    828f914 View commit details
    Browse the repository at this point in the history

  5. position_file: Use ternary operator to simplify clause 

    Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
    @cosmo0920
    cosmo0920 committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    bc06026 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. in_tail: Use target_info.path instead of path on string interpolation 

    Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
    @cosmo0920
    cosmo0920 committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    9c18848 View commit details
    Browse the repository at this point in the history

  2. in_tail: Use target_info instead of path_ino name 

    Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
    @cosmo0920
    cosmo0920 committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    17b5d82 View commit details
    Browse the repository at this point in the history

  3. in_tail: Restore rotated target info line 

    Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
    @cosmo0920
    cosmo0920 committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    a106a03 View commit details
    Browse the repository at this point in the history

  4. position_file: Use ternary operator in early return on #[] 

    Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
    @cosmo0920
    cosmo0920 committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    978551e View commit details
    Browse the repository at this point in the history