in_tcp: show listening address and port for consistency with in_udp #3213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in_udp plugin shows log message when starting server, but this behavior is not true for in_tcp plugin. For consistency it is better to show startup message. [info]: #0 listening tcp socket bind="..." port=... Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
cosmo0920
reviewed
Dec 23, 2020
| @@ -98,6 +98,7 @@ def multi_workers_ready? | |||
| def start | |||
| super | |||
|
|
|||
| log.info "listening tcp socket", bind: @bind, port: @port | |||
There was a problem hiding this comment.
👍
NOTE: in_udp plugin:
https://github.com/fluent/fluentd/blob/master/lib/fluent/plugin/in_udp.rb#L71
cosmo0920
approved these changes
Dec 23, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Not bound to specific issue
What this PR does / why we need it:
in_udp plugin shows log message when starting server, but this
behavior is not true for in_tcp plugin.
For consistency it is better to show startup message.
[info]: #0 listening tcp socket bind="..." port=...
This change is introduced that there is a case that inconsistency log
leads confusion when in_tcp and in_udp is used at the same time.
Docs Changes:
N/A
Release Note:
N/A