Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test in_tail: use safer method to cleanup #3283

Merged
merged 2 commits into from
Mar 9, 2021
Merged

test in_tail: use safer method to cleanup #3283

merged 2 commits into from
Mar 9, 2021

Commits on Mar 9, 2021

  1. test in_tail: use safer method to cleanup 

    This PR aims to fix in_tail test cases on Windows.

On Windows, when the file or directory is removed and created
frequently, there is a case that creating file or directory will fail.
This situation is caused by pending file or directory deletion which
is mentioned on win32 API document.

ref. https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilea#files

As a workaround, execute rename and remove method.

Signed-off-by: Kentaro Hayashi <kenhys@gmail.com>
    @kenhys
    kenhys committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    392b6d4 View commit details
    Browse the repository at this point in the history

  2. test: add missing tmpdir 

    Signed-off-by: Kentaro Hayashi <kenhys@gmail.com>
    @kenhys
    kenhys committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    c78301a View commit details
    Browse the repository at this point in the history