Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some failed tests of #3288 on Windows #3289

Merged
merged 1 commit into from Mar 9, 2021

Conversation

ashie
Copy link
Member

@ashie ashie commented Mar 9, 2021

Which issue(s) this PR fixes:
Follow up for #3288

What this PR does / why we need it:
In #3288, some tests are failed on #3288 due to mismatched line breaks.

Docs Changes:
none

Release Note:
none

Line breaks should be "\r\n".

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
@ashie ashie assigned cosmo0920 and unassigned cosmo0920 Mar 9, 2021
@ashie ashie requested a review from cosmo0920 March 9, 2021 06:58
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'd overlooked these failures....

@cosmo0920 cosmo0920 merged commit 5a6fd93 into fluent:master Mar 9, 2021
@ashie ashie deleted the follow-up-#3288 branch March 9, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants