Fix an unstable test for ack response of out_forward #3313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashie
force-pushed
the
fix-wrong-ack-test
branch
from
a350a50
to
d6de4f0
Compare
ashie
changed the title
ashie
force-pushed
the
fix-wrong-ack-test
branch
from
d6de4f0
to
92c2db9
Compare
It fixes the following error: Error: test: a node supporting responses after stop(ForwardOutputTest): Fluent::Test::Driver::TestTimedOut: Test case timed out with hard limit. /home/runner/work/fluentd/fluentd/lib/fluent/test/driver/base.rb:201:in `rescue in run_actual' /home/runner/work/fluentd/fluentd/lib/fluent/test/driver/base.rb:196:in `run_actual' /home/runner/work/fluentd/fluentd/lib/fluent/test/driver/base.rb:95:in `run' /home/runner/work/fluentd/fluentd/lib/fluent/test/driver/base_owner.rb:130:in `run' /home/runner/work/fluentd/fluentd/test/plugin/test_out_forward.rb:651:in `block in <class:ForwardOutputTest>' In addition, add a timeout and an assertion to help investigating on failure/error cases. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
ashie
force-pushed
the
fix-wrong-ack-test
branch
from
92c2db9
to
22a3e14
Compare
|
Hmm, frequency of occurrence is quite reduced but not yet perfect: https://github.com/fluent/fluentd/runs/2250361051 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
none
What this PR does / why we need it:
It fixes the following error:
In addition, add a timeout and an assertion to help investigating on failure/error cases.
Docs Changes:
none
Release Note:
none