Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for configuration of OJ options #3315

Merged
merged 11 commits into from
Jul 9, 2021
Merged

Allow for configuration of OJ options #3315

merged 11 commits into from
Jul 9, 2021

Commits on Jul 8, 2021

  1. Allow for setting of OJ Options 

    Signed-off-by: Conor Evans <coevans@tcd.ie>
    @conorevans @ashie
    conorevans authored and ashie committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    7f8afda View commit details
    Browse the repository at this point in the history

  2. It is compat, and not concat 

    Signed-off-by: Conor Evans <coevans@tcd.ie>
    @conorevans @ashie
    conorevans authored and ashie committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    5e35c60 View commit details
    Browse the repository at this point in the history

  3. newline 

    Signed-off-by: Conor Evans <coevans@tcd.ie>
    @conorevans @ashie
    conorevans authored and ashie committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    2b16490 View commit details
    Browse the repository at this point in the history

  4. refactor: address PR comments.. 1) remove EnvUtils module and move Oj… 

    …Options directly under Fluent, 2) use strict=true in reformatted value and return the int parsing back to normal as that is a breaking change

Signed-off-by: Conor Evans <coevans@tcd.ie>
    @conorevans @ashie
    conorevans authored and ashie committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    68ed3b5 View commit details
    Browse the repository at this point in the history

  5. add types tests, update symbol type to return nil for '' too 

    Signed-off-by: Conor Evans <coevans@tcd.ie>
    @conorevans @ashie
    conorevans authored and ashie committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    fb096df View commit details
    Browse the repository at this point in the history

  6. fix typo: concat should be compat 

    Signed-off-by: Conor Evans <coevans@tcd.ie>
    @conorevans @ashie
    conorevans authored and ashie committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    30044f4 View commit details
    Browse the repository at this point in the history

  7. test: Restore ENV after testing OjOptions 

    Signed-off-by: Takuro Ashie <ashie@clear-code.com>
    @ashie
    ashie committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    d9968a3 View commit details
    Browse the repository at this point in the history

  8. OjOptions: Remove needless prefix of constants 

    Signed-off-by: Takuro Ashie <ashie@clear-code.com>
    @ashie
    ashie committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    54e0cc2 View commit details
    Browse the repository at this point in the history

  9. OjOptions: Remove needless instantiation 

    Signed-off-by: Takuro Ashie <ashie@clear-code.com>
    @ashie
    ashie committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    beae9f7 View commit details
    Browse the repository at this point in the history

  10. Set Oj.default_options only once when fluentd is started 

    It shouldn't be set by each plugins, because later loaded plugins will
overwrites it.

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
    @ashie
    ashie committed Jul 8, 2021
    1 Configuration menu
    Copy the full SHA
    3217fe4 View commit details
    Browse the repository at this point in the history

  11. OjOptions: Don't require needless files 

    Signed-off-by: Takuro Ashie <ashie@clear-code.com>
    @ashie
    ashie committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    05c3cf2 View commit details
    Browse the repository at this point in the history