Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WindowsFile: Show the path when Win32Error is occured #3329

Merged
merged 1 commit into from Apr 13, 2021

Conversation

ashie
Copy link
Member

@ashie ashie commented Apr 13, 2021

Which issue(s) this PR fixes:
none

What this PR does / why we need it:
In #3325 we added Win32Error to show Windows specific errors correctly,
but it's not enough for debugging because it doesn't show which file
causes the error.

Docs Changes:
none

Release Note:
none, same with #3325

In fluent#3325 we added Win32Error to show Windows specific errors correctly,
but it's not enough for debugging because it doesn't show which file
causes the error.

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
@ashie ashie requested review from cosmo0920 and kenhys April 13, 2021 04:59
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks attractive for me.

Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ashie ashie merged commit 07df9a0 into fluent:master Apr 13, 2021
@ashie ashie deleted the followup-#3325 branch April 13, 2021 05:25
@ashie
Copy link
Member Author

ashie commented Apr 14, 2021

Hmm, it's still not enough. to_s is missing so that it shows only "Fluent::Win32Error".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants