Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid to crash on outputting log at the early stage config parser #3451

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Avoid to crash on outputting log at the early stage config parser #3451

merged 2 commits into from
Jul 8, 2021

Commits on Jul 8, 2021

  1. Avoid to crash on outputting log at the early stage config parser 

    By #3352, an early stage config parser is introduced to enable setting
log rotation by system config. While this stage, the global logger
doesn't exist yet, so that it causes crash when the config parser try to
output log. This commit avoid the crash by checking $log. Same logs will
be output at the later stage so that it's not needed in the early stage.

See also: fluent/fluentd-kubernetes-daemonset#583

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
    @ashie
    ashie committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    f94fdb0 View commit details
    Browse the repository at this point in the history

  2. Check one more $log usage while parsing a config file 

    Signed-off-by: Takuro Ashie <ashie@clear-code.com>
    @ashie
    ashie committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    fe1b56a View commit details
    Browse the repository at this point in the history