WindowsFile: Add testing for DeletePending #3460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think I found a way to add testing for the changeset f61c08c. 1. Create a test file with FILE_SHARE_DELETE mode. 2. Call DeleteFile() on that file. 3. Call stat() on that file. 4. Check if ENOENT is raised in step 3. Confirmed to work fine on GitHub Action: WindowsFile exceptions: test: ERROR_SHARING_VIOLATION raised: .: (0.001220) test: Errno::ENOENT raised: .: (0.000633) test: Errno::ENOENT raised on DeletePending: .: (0.000717) test: nothing raised: .: (0.000835) Signed-off-by: Fujimoto Seiji <fujimoto@ceptord.net>
fujimotos
force-pushed
the
sf/deletepending-test
branch
from
a1ebeea
to
dde8efe
Compare
fujimotos
changed the title
|
I confirmed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Ammend #3457
What this PR does / why we need it:
I think I found a way to add testing for the changeset f61c08c.
DeleteFile()on that file.WindowsFile.stat()on that file.Confirmed to work fine on GitHub Action:
Docs Changes:
Not required.
Release Note:
Not required.