in_tail: Fix a regression of retrying unaccessible files #3477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests for it should be added. |
|
In addition, it's better to decrease frequency of retrying: #903 |
When a fluentd proccess doesn't have permision to read a file, it should retry to open it again. But the current implementation doesn't do it due to a bug introduced at #3378. This pull request intend to rescue EACCESS on stat(2) but it also rescue it on open(2) wrongly. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
ashie
force-pushed
the
in-tail-fix-retrying
branch
from
5dc65e1
to
fc6dfa4
Compare
|
Hmm, it's not a regression, it retries on every tail watcher timer (1 sec). The only thing we should do is adding warning message for it. |
This was referenced Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
None.
Follow up of #3378
What this PR does / why we need it:
When a fluentd proccess doesn't have permision to read a file, it should
retry to open it again. But the current implementation doesn't do it due
to a bug introduced at #3378. This pull request intend to rescue EACCESS
on stat(2) but it also rescue it on open(2) wrongly.
Docs Changes:
None
Release Note:
Same with the title.