input: filter: output: bare_output: multi_output: Use metrics plugin mechanism on plugin base classes #3479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
…iguring is done Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
if needn't Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
cosmo0920
force-pushed
the
use-metrics-plugin-mechanism-on-plugin-base-classes
branch
from
e499589
to
e9b3d27
Compare
|
Hmm, all CI tasks are failed. We should check them. |
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
I fixed it. |
ashie
requested changes
Jul 31, 2021
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
ashie
approved these changes
Aug 2, 2021
cosmo0920
deleted the
use-metrics-plugin-mechanism-on-plugin-base-classes
branch
|
I found that we should do additional work for prometheus plugin. I'll send another PR. o/ |
|
I'd confirmed that, in Fluentd side, there is no additional work is needed but prometheus plugin should follow this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
None
What this PR does / why we need it:
This is the last PR series for implementing metrics plugin mechanism.
With these changes, our cmetrics metrics plugin can work with Fluentd and Fluentd can handle native metrics to send prometheus via fluent-plugin-metrics-cmetrics which binds cmetrics library.
Performance degradation will be prevented with 97486d1 and e499589. Locking with Monitor is heavy operation when it needn't to use due to disable size metrics on each plugin base classes.
Docs Changes:
Needed.
Release Note:
Same as title.