out_forward: Include before merging stats information correctly #3507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hash#merge does not merge within nested values. They should be handled by hands. Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
|
Ah, sorry, I also missed it. |
|
Yeah, this behavior is pitfall. Now I understand why Rails provides Hash#deep_merge.... 😢 |
ashie
approved these changes
Sep 14, 2021
|
I'll merge this PR after CIs are finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hiroshi Hatake hatake@calyptia.com
Which issue(s) this PR fixes:
Follows up #3503
What this PR does / why we need it:
Hash#merge does not merge within nested values.
They should be handled by hands.
Docs Changes:
No needed.
Release Note:
Same as title.