Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluent-cat: support to send event time in specified timestamp #3528

Merged
merged 1 commit into from
Oct 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 13 additions & 3 deletions lib/fluent/command/cat.rb
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
message_key = 'message'
time_as_integer = false
retry_limit = 5
event_time = nil

op.on('-p', '--port PORT', "fluent tcp port (default: #{port})", Integer) {|i|
port = i
Expand Down Expand Up @@ -80,6 +81,10 @@
retry_limit = n
}

op.on('--event-time TIME_STRING', "Specify the time expression string (default: nil)") {|v|
event_time = v
}

singleton_class.module_eval do
define_method(:usage) do |msg|
puts op.to_s
Expand Down Expand Up @@ -134,7 +139,7 @@ def run
end
end

def initialize(tag, connector, time_as_integer: false, retry_limit: 5)
def initialize(tag, connector, time_as_integer: false, retry_limit: 5, event_time: nil)
@tag = tag
@connector = connector
@socket = false
Expand All @@ -148,6 +153,7 @@ def initialize(tag, connector, time_as_integer: false, retry_limit: 5)
@retry_wait = 1
@retry_limit = retry_limit
@time_as_integer = time_as_integer
@event_time = event_time

super()
end
Expand All @@ -166,7 +172,11 @@ def write(record)
end
end

time = Fluent::EventTime.now
time = if @event_time
Fluent::EventTime.parse(@event_time)
else
Fluent::EventTime.now
end
time = time.to_i if @time_as_integer
entry = if secondary_record?(record)
# Even though secondary contains Fluent::EventTime in record,
Expand Down Expand Up @@ -309,7 +319,7 @@ def abort_message(time, record)
}
end

w = Writer.new(tag, connector, time_as_integer: time_as_integer, retry_limit: retry_limit)
w = Writer.new(tag, connector, time_as_integer: time_as_integer, retry_limit: retry_limit, event_time: event_time)
w.start

case format
Expand Down
29 changes: 29 additions & 0 deletions test/command/test_cat.rb
Original file line number Diff line number Diff line change
Expand Up @@ -96,4 +96,33 @@ def test_cat_secondary_file
[d.events.size, event.first, event.last])
end
end

sub_test_case "send specific event time" do
def test_without_event_time
event_time = Fluent::EventTime.now
d = create_driver
d.run(expect_records: 1) do
Open3.pipeline_w("#{ServerEngine.ruby_bin_path} #{FLUENT_CAT_COMMAND} --port #{@port} tag") do |stdin|
stdin.puts('{"key":"value"}')
stdin.close
end
end
event = d.events.first
assert_in_delta(event_time.to_f, event[1].to_f, 3.0) # expect command to be finished in 3 seconds
assert_equal([1, "tag", true, @record],
[d.events.size, event.first, event_time.to_f < event[1].to_f, event.last])
end

def test_with_event_time
event_time = "2021-01-02 13:14:15.0+00:00"
d = create_driver
d.run(expect_records: 1) do
Open3.pipeline_w("#{ServerEngine.ruby_bin_path} #{FLUENT_CAT_COMMAND} --port #{@port} --event-time '#{event_time}' tag") do |stdin|
stdin.puts('{"key":"value"}')
stdin.close
end
end
assert_equal([["tag", Fluent::EventTime.parse(event_time), @record]], d.events)
end
end
end