Show chunk_limit_size respectively #3562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is more informative and distinguishable. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
ashie
approved these changes
Nov 24, 2021
Merged
kenhys
added a commit
to kenhys/fluentd
that referenced
this pull request
Nov 29, 2021
There is a case that processing unexpected long line causes a BufferChunkOverflow exception. With fluent#3562 (Fluentd v1.14.3), it can just ignore only problematic long record, but it always raise an exception. Thus it has performance regression. In this fix, skip_long_lines option enables to just skip processing event further more. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
added a commit
to kenhys/fluentd
that referenced
this pull request
Nov 30, 2021
There is a case that processing unexpected long line causes a BufferChunkOverflow exception. With fluent#3562 (Fluentd v1.14.3), it can just ignore only problematic long record during processing buffer chunk, but it always raise an exception. Thus it has performance regression. In this fix, skip_long_lines option enables to just skip processing event further more in in_tail plugin side. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
added a commit
to kenhys/fluentd
that referenced
this pull request
Nov 30, 2021
There is a case that processing unexpected long line causes a BufferChunkOverflow exception. With fluent#3562 (Fluentd v1.14.3), it can just ignore only problematic long record during processing buffer chunk, but it always raise an exception. Thus it has performance regression. In this fix, skip_long_lines option enables to just skip processing event further more in in_tail plugin side. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
added a commit
to kenhys/fluentd
that referenced
this pull request
Nov 30, 2021
There is a case that processing unexpected long line causes a BufferChunkOverflow exception. With fluent#3562 (Fluentd v1.14.3), it can just ignore only problematic long record during processing buffer chunk, but it always raise an exception. Thus it has performance regression. In this fix, skip_long_lines option enables to just skip processing event further more in in_tail plugin side. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
added a commit
to kenhys/fluentd
that referenced
this pull request
Dec 1, 2021
There is a case that processing unexpected long line causes a BufferChunkOverflow exception. With fluent#3562 (Fluentd v1.14.3), it can just ignore only problematic long record during processing buffer chunk, but it always raise an exception. Thus it has performance regression. In this fix, skip_long_lines option enables to just skip processing event further more in in_tail plugin side. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
added a commit
to kenhys/fluentd
that referenced
this pull request
Dec 1, 2021
There is a case that processing unexpected long line causes a BufferChunkOverflow exception. With fluent#3562 (Fluentd v1.14.3), it can just ignore only problematic long record during processing buffer chunk, but it always raise an exception. Thus it has performance regression. In this fix, maximum_line_limit_size option enables to just skip processing event further more in in_tail plugin side. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
added a commit
to kenhys/fluentd
that referenced
this pull request
Dec 1, 2021
There is a case that processing unexpected long line causes a BufferChunkOverflow exception. With fluent#3562 (Fluentd v1.14.3), it can just ignore only problematic long record during processing buffer chunk, but it always raise an exception. Thus it has performance regression. In this fix, max_line_size option enables to just skip processing event further more in in_tail plugin side. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
added a commit
that referenced
this pull request
Dec 2, 2021
There is a case that processing unexpected long line causes a BufferChunkOverflow exception. With #3562 (Fluentd v1.14.3), it can just ignore only problematic long record during processing buffer chunk, but it always raise an exception. Thus it has performance regression. In this fix, max_line_size option enables to just skip processing event further more in in_tail plugin side. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #3553
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
No functionality changes.
It is more informative and distinguishable.
Docs Changes:
Release Note: