Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make out_file append option work without compression #3579

Merged
merged 4 commits into from Dec 28, 2021
Merged

Make out_file append option work without compression #3579

merged 4 commits into from Dec 28, 2021

Commits on Dec 22, 2021

  1. Make out_file append option work without compression 

    For Ruby 2.7.x and 3.0.x, out_file append option without compression
does not work. The cause is the following Ruby language bug:

https://bugs.ruby-lang.org/issues/18388.

This commit is a workaround for this problem.

See fluent#3569.

Signed-off-by: Jingguo Yao <yaojingguo@gmail.com>
    @yaojingguo
    yaojingguo committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    a61c1e3 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2021

  1. Apply workaround for fluent#3569 only on macOS 

    Signed-off-by: Takuro Ashie <ashie@clear-code.com>
    @ashie
    ashie committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    94df99f View commit details
    Browse the repository at this point in the history

  2. Add test case for append option without compression 

    See fluent#3569.

Signed-off-by: Jingguo Yao <yaojingguo@gmail.com>
    @yaojingguo @ashie
    yaojingguo authored and ashie committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    a31d17f View commit details
    Browse the repository at this point in the history

  3. test_out_file: Don't extract the content of "test append" as a method 

    Use data driven test instead to make easy to read.

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
    @ashie
    ashie committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    f17cb9e View commit details
    Browse the repository at this point in the history