Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.14.4 #3589

Merged
merged 1 commit into from Jan 6, 2022
Merged

v1.14.4 #3589

merged 1 commit into from Jan 6, 2022

Conversation

fujimotos
Copy link
Member

  • This is the pull request for upcoming v1.14.4 release.
  • If anything is missing from my release note, please comment here.
    (I'm going to fast-forward this branch tomorrow)

@fujimotos fujimotos requested review from ashie and kenhys January 5, 2022 08:50
@fujimotos fujimotos mentioned this pull request Jan 5, 2022
Closed
ashie
ashie requested changes Jan 5, 2022
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@kenhys
Copy link
Contributor

kenhys commented Jan 5, 2022

It looks good if the above 2 issues were fixed.

@fujimotos
v1.14.4
d1f33da 
Signed-off-by: Fujimoto Seiji <fujimoto@ceptord.net>
@fujimotos
Copy link
Member Author

fujimotos commented Jan 6, 2022 •
edited

So I was poking around the CHANGELOG.md this morning. I ended up adding a few fixes:

  • The bug-fix section contains more detailed explanation about what was fixed.
    • e.g. On macOS with Ruby 2.7/3.0, out_file fails to write events if append is true.
  • Use backticks to escape underscore characters.

kenhys
kenhys approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fujimotos fujimotos merged commit d1f33da into fluent:master Jan 6, 2022
@fujimotos fujimotos deleted the sf/v1.14.4 branch January 6, 2022 04:41
@fujimotos
Copy link
Member Author

Merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashie ashie ashie approved these changes

@kenhys kenhys kenhys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fujimotos @kenhys @ashie