Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stay Async's version to 1.x #3592

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Stay Async's version to 1.x #3592

merged 1 commit into from
Jan 13, 2022

Commits on Jan 6, 2022

  1. Stay Async's version to 1.x

    Async::HTTP unlocks using Async-2.x since v0.56.4.
    But we aren't ready for Async-2.0 yet, one of the known issue is that
    it causes the following error:
    
    #3585 (comment):
    
    ```
    2021-12-27T14:53:29.8037858Z Error: test: monunt given path(HttpHelperTest::Create a HTTP server): ArgumentError: unknown keyword: :logger
    2021-12-27T14:53:29.8040011Z /opt/hostedtoolcache/Ruby/3.1.0/x64/lib/ruby/gems/3.1.0/gems/async-2.0.0/lib/async/scheduler.rb:39:in `initialize'
    2021-12-27T14:53:29.8041621Z /opt/hostedtoolcache/Ruby/3.1.0/x64/lib/ruby/gems/3.1.0/gems/async-2.0.0/lib/async/reactor.rb:32:in `initialize'
    2021-12-27T14:53:29.8043219Z /home/runner/work/fluentd/fluentd/lib/fluent/plugin_helper/http_server/server.rb:41:in `new'
    2021-12-27T14:53:29.8045446Z /home/runner/work/fluentd/fluentd/lib/fluent/plugin_helper/http_server/server.rb:41:in `initialize'
    2021-12-27T14:53:29.8046959Z /home/runner/work/fluentd/fluentd/lib/fluent/plugin_helper/http_server.rb:69:in `new'
    2021-12-27T14:53:29.8048253Z /home/runner/work/fluentd/fluentd/lib/fluent/plugin_helper/http_server.rb:69:in `http_server_create_http_server'
    2021-12-27T14:53:29.8049705Z /home/runner/work/fluentd/fluentd/test/plugin_helper/test_http_server_helper.rb:157:in `block (3 levels) in <class:HttpHelperTest>'
    2021-12-27T14:53:29.8051313Z /home/runner/work/fluentd/fluentd/test/plugin_helper/test_http_server_helper.rb:36:in `on_driver'
    2021-12-27T14:53:29.8052768Z /home/runner/work/fluentd/fluentd/test/plugin_helper/test_http_server_helper.rb:156:in `block (2 levels) in <class:HttpHelperTest>'
    ```
    
    Signed-off-by: Takuro Ashie <ashie@clear-code.com>
    ashie committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    7d39f07 View commit details
    Browse the repository at this point in the history