-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong calcuration of retry interval and detecting retry limit #3649
Commits on Mar 23, 2022
-
retry_state: Fix wrong calcuration of interval
The correct total retry time should be: c + c * b^1 + (...) + c*b^(k - 1) But the previous implementation was: c + c * b^0 + c * b^1 + (...) + c*b^(k - 1) where: * c: constant factor, @retry_wait * b: base factor, @retry_exponential_backoff_base * k: number of retry times, @max_retry_times Although the first retry interval is already added at constructor of ExponentialBackoffRetry, same value is added again unexpectedly on the first calc_interval call (as `c * b^0`). Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Configuration menu - View commit details
-
Copy full SHA for 2bfa8d8 - Browse repository at this point
Copy the full SHA 2bfa8d8View commit details -
Fix wrong retry limit detection
The previous implementation detects @max_retry_times + 1 as limit, but the limit should be @max_retry_times. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Configuration menu - View commit details
-
Copy full SHA for adae64a - Browse repository at this point
Copy the full SHA adae64aView commit details -
Simplify handling limit steps of retry
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Configuration menu - View commit details
-
Copy full SHA for 7e29932 - Browse repository at this point
Copy the full SHA 7e29932View commit details -
test_output_as_buffered_secondary: Follow a recent change
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Configuration menu - View commit details
-
Copy full SHA for a2cbb42 - Browse repository at this point
Copy the full SHA a2cbb42View commit details
Commits on Mar 24, 2022
-
Add scenario test of RetryState
RetryStatement behavior is complicated, so scenario tests may be useful. Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
Configuration menu - View commit details
-
Copy full SHA for 09f0aa5 - Browse repository at this point
Copy the full SHA 09f0aa5View commit details -
Add 2 states to control timeout. Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
Configuration menu - View commit details
-
Copy full SHA for 4819ccf - Browse repository at this point
Copy the full SHA 4819ccfView commit details -
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
Configuration menu - View commit details
-
Copy full SHA for e3f5034 - Browse repository at this point
Copy the full SHA e3f5034View commit details
Commits on Mar 25, 2022
-
output: Unify logging retry error
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Configuration menu - View commit details
-
Copy full SHA for a4f15f9 - Browse repository at this point
Copy the full SHA a4f15f9View commit details