-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_in_tail: Fix unstable tests #3767
Commits on Jun 1, 2022
-
test_in_tail: Fix wrong rotation tests on Windows
`sub_test_rotate_file` should pass a rotated file to block, not a new file. In addition, it should be opened by `Fluent::FileWrapper` to avoid locking. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Configuration menu - View commit details
-
Copy full SHA for 3fbcc11 - Browse repository at this point
Copy the full SHA 3fbcc11View commit details -
test_in_tail: Check emitted events of rotation tests by one `assert_e…
…qual` Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Configuration menu - View commit details
-
Copy full SHA for eec3974 - Browse repository at this point
Copy the full SHA eec3974View commit details -
test_in_tail: Make sure to wait completing first read
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Configuration menu - View commit details
-
Copy full SHA for 65af256 - Browse repository at this point
Copy the full SHA 65af256View commit details -
test_in_tail: Always create new temp directory for each tests
On windows, sometimes fails to remove old test files, it makes tests unstable. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Configuration menu - View commit details
-
Copy full SHA for 90ad37d - Browse repository at this point
Copy the full SHA 90ad37dView commit details -
test_in_tail: Simplify cleanup_directory and cleanup_file
Since we always create a new test ditectory on each tests, ensuring to remove old directory in hacky way is no longer needed. In addition, we already dropped Ruby 2.6 support, and the previous implementation has some bugs. For example `FileUtils.rm_f` doesn't have `secure` option even though the latest Ruby (v3.1), probably it intend `FileUtils.rm_r`. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Configuration menu - View commit details
-
Copy full SHA for a065d02 - Browse repository at this point
Copy the full SHA a065d02View commit details -
test_in_tail: Fix failed tests on GNU/Linux
* TestWithSystem should call super at setup and teadown * EX_* should be placed just under TailInputTest Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Configuration menu - View commit details
-
Copy full SHA for bcba06f - Browse repository at this point
Copy the full SHA bcba06fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f3b7f3 - Browse repository at this point
Copy the full SHA 4f3b7f3View commit details -
test_in_tail: Fix some omitted tests on Windows
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Configuration menu - View commit details
-
Copy full SHA for e041b61 - Browse repository at this point
Copy the full SHA e041b61View commit details