Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop win32-api gem #3849

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Drop win32-api gem #3849

merged 2 commits into from
Aug 9, 2022

Commits on Aug 9, 2022

  1. Remove dependency to win32-api gem 

    Recently we fail to load win32-api on Ruby 3.2-dev:
https://github.com/fluent/fluentd/runs/7660210030?check_suite_focus=true

  D:/rubyinstaller-head-x64/lib/ruby/gems/3.2.0+2/gems/windows-api-0.4.5/lib/windows/api.rb:335:in `initialize': uninitialized constant Win32::API (NameError)
        @api = Win32::API.new(func, proto, rtype, dll)
                    ^^^^^
          from D:/rubyinstaller-head-x64/lib/ruby/gems/3.2.0+2/gems/windows-pr-1.2.6/lib/windows/msvcrt/string.rb:12:in `new'

but Fluentd doesn't seem depend on win32-api so much.
Using Fiddle is enough instead. It's time to drop win32-api gem.

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
    @ashie
    ashie committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    7d55f79 View commit details
    Browse the repository at this point in the history

  2. Extract Win32 FFI code to lib/fluent/win32.rb 

    Signed-off-by: Takuro Ashie <ashie@clear-code.com>
    @ashie
    ashie committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    f1f0bb2 View commit details
    Browse the repository at this point in the history