Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove meaningless oj options #3929

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Remove meaningless oj options #3929

merged 2 commits into from
Oct 27, 2022

Commits on Oct 27, 2022

  1. Remove object from the available list of FLUENT_OJ_OPTION_MODE 

    There is less benefit by this option in actual, and it will instroduce
serious security risk since it can execute arbitrary Ruby code.
We remove it since keeping it secure is difficult.

ref: GHSL-2022-067

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
    @ashie
    ashie committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    48e5b85 View commit details
    Browse the repository at this point in the history

  2. Remove FLUENT_OJ_OPTION_MAX_NESTING 

    This option doesn't take effect in actual since the global setting
`Oj.default_options` doesn't accept `max_nesting`. It should be
specified by each instances.

#3311 (comment)

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
    @ashie
    ashie committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    3c417bb View commit details
    Browse the repository at this point in the history