Merge pull request #1817 from jnyrup/Cleanup

Fix uninvoked actions
fluentassertions · Feb 18, 2022 · 7092c0b · 7092c0b
2 parents bd9cc8c + 5de1802
commit 7092c0b
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 9 deletions.
diff --git a/Src/FluentAssertions/Execution/AssertionScope.cs b/Src/FluentAssertions/Execution/AssertionScope.cs
@@ -401,7 +401,7 @@ public void Dispose()
             }
             else
             {
-                IDictionary<string,object> reportable = contextData.GetReportable();
+                IDictionary<string, object> reportable = contextData.GetReportable();
 
                 if (tracing.Length > 0)
                 {

diff --git a/Tests/FluentAssertions.Specs/AndWhichConstraintSpecs.cs b/Tests/FluentAssertions.Specs/AndWhichConstraintSpecs.cs
@@ -16,7 +16,7 @@ public void When_many_objects_are_provided_accessing_which_should_throw_a_descri
             // Act
             Action act = () =>
             {
-                var item = continuation.Which;
+                _ = continuation.Which;
             };
 
             // Assert

diff --git a/Tests/FluentAssertions.Specs/Collections/GenericCollectionAssertionOfStringSpecs.cs b/Tests/FluentAssertions.Specs/Collections/GenericCollectionAssertionOfStringSpecs.cs
@@ -1714,7 +1714,7 @@ public void When_collection_contains_multiple_matches_which_should_throw()
             // Act
             Action action = () =>
             {
-                string item = collection.Should().ContainMatch("* failed").Which;
+                _ = collection.Should().ContainMatch("* failed").Which;
             };
 
             // Assert

diff --git a/Tests/FluentAssertions.Specs/ConfigurationSpecs.cs b/Tests/FluentAssertions.Specs/ConfigurationSpecs.cs
@@ -19,10 +19,10 @@ public void When_concurrently_accessing_current_Configuration_no_exception_shoul
                 {
                     MaxDegreeOfParallelism = 8
                 },
-                _ =>
+                __ =>
                 {
                     Configuration.Current.ValueFormatterAssembly = string.Empty;
-                    var mode = Configuration.Current.ValueFormatterDetectionMode;
+                    _ = Configuration.Current.ValueFormatterDetectionMode;
                 }
             );
 

diff --git a/Tests/FluentAssertions.Specs/Formatting/PredicateLambdaExpressionValueFormatterSpecs.cs b/Tests/FluentAssertions.Specs/Formatting/PredicateLambdaExpressionValueFormatterSpecs.cs
@@ -59,7 +59,6 @@ public void When_condition_contains_extension_method_then_extension_method_must_
         public void When_condition_contains_linq_extension_method_then_extension_method_must_be_formatted()
         {
             // Arrange
-            var actual = new[] { 4 };
             var allowed = new[] { 1, 2, 3 };
 
             // Act

diff --git a/Tests/FluentAssertions.Specs/Primitives/StringAssertionSpecs.cs b/Tests/FluentAssertions.Specs/Primitives/StringAssertionSpecs.cs
@@ -3657,7 +3657,7 @@ public void When_an_upper_case_string_with_numbers_is_not_supposed_to_be_in_uppe
             string actual = "a1";
 
             // Act / Assert
-            Action act = () => actual.Should().NotBeUpperCased();
+            actual.Should().NotBeUpperCased();
         }
 
         [Fact]
@@ -3792,7 +3792,7 @@ public void When_a_lower_case_string_with_numbers_is_not_supposed_to_be_in_lower
             string actual = "A1";
 
             // Act / Assert
-            Action act = () => actual.Should().NotBeLowerCased();
+            actual.Should().NotBeLowerCased();
         }
 
         [Fact]

diff --git a/Tests/FluentAssertions.Specs/Types/MethodInfoSelectorSpecs.cs b/Tests/FluentAssertions.Specs/Types/MethodInfoSelectorSpecs.cs
@@ -332,7 +332,7 @@ public void When_selecting_methods_that_are_not_virtual_it_should_only_return_th
                 .And.NotContain(m => m.Name == "PublicVirtualVoidMethodWithAttribute")
                 .And.NotContain(m => m.Name == "ProtectedVirtualVoidMethodWithAttribute");
         }
-        
+
         [Fact]
         public void When_selecting_methods_that_are_static_it_should_only_return_the_applicable_methods()
         {