Merge pull request #1736 from jnyrup/asyncCleanup

Return Task for async/non-async test method
fluentassertions · Nov 9, 2021 · 8388e8d · 8388e8d
2 parents 31fb3cf + 04b4a71
commit 8388e8d
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/Tests/FluentAssertions.Specs/Types/MethodInfoSelectorSpecs.cs b/Tests/FluentAssertions.Specs/Types/MethodInfoSelectorSpecs.cs
@@ -284,7 +284,7 @@ public void When_selecting_methods_that_are_async_it_should_only_return_the_appl
 
             // Assert
             methods.Should().ContainSingle()
-                .Which.Name.Should().Be("PublicVoidAsyncMethod");
+                .Which.Name.Should().Be("PublicAsyncMethod");
         }
 
         [Fact]
@@ -298,7 +298,7 @@ public void When_selecting_methods_that_are_not_async_it_should_only_return_the_
 
             // Assert
             methods.Should().ContainSingle()
-                .Which.Name.Should().Be("PublicVoidNotAsyncMethod");
+                .Which.Name.Should().Be("PublicNonAsyncMethod");
         }
 
         [Fact]
@@ -398,12 +398,9 @@ internal class TestClassForMethodSelectorWithNonInheritableAttributeDerived : Te
 
     internal class TestClassForMethodSelectorWithAsyncAndNonAsyncMethod
     {
-        public async void PublicVoidAsyncMethod()
-        {
-            await Task.Yield();
-        }
+        public async Task PublicAsyncMethod() => await Task.Yield();
 
-        public void PublicVoidNotAsyncMethod() { }
+        public Task PublicNonAsyncMethod() => Task.CompletedTask;
     }
 
     internal class TestClassForMethodReturnTypesSelector