Merge pull request #2122 from AArnott/fix2121

Declare System.Net.Http as a framework dependency
fluentassertions · Feb 9, 2023 · 97cf195 · 97cf195
2 parents d26a45d + bb9868f
commit 97cf195
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/Src/FluentAssertions/FluentAssertions.csproj b/Src/FluentAssertions/FluentAssertions.csproj
@@ -91,7 +91,10 @@
   </ItemGroup>
   <ItemGroup Condition="'$(TargetFramework)' == 'net47'">
     <PackageReference Include="System.Threading.Tasks.Extensions" Version="4.5.0" />
-    <PackageReference Include="System.Net.Http" Version="4.3.4" />
+    <TfmSpecificFrameworkAssemblyReferences Include="System.Net.Http">
+      <TargetFramework>$(TargetFramework)</TargetFramework>
+    </TfmSpecificFrameworkAssemblyReferences>
+    <Reference Include="System.Net.Http" />
     <Reference Include="System.Configuration" />
     <Reference Include="System.Data" />
     <Reference Include="System.Xml" />

diff --git a/Tests/Benchmarks/Benchmarks.csproj b/Tests/Benchmarks/Benchmarks.csproj
@@ -15,5 +15,6 @@
   </ItemGroup>
   <ItemGroup>
     <Reference Include="System.Data.DataSetExtensions" Condition="'$(TargetFramework)' == 'net472'" />
+    <Reference Include="System.Net.Http" Condition="'$(TargetFramework)' == 'net472'" />
   </ItemGroup>
 </Project>
diff --git a/docs/_pages/releases.md b/docs/_pages/releases.md
@@ -16,6 +16,8 @@ sidebar:
 
 * `BeEquivalentTo` no longer crashes on fields hiding base-class fields - [#1990](https://github.com/fluentassertions/fluentassertions/pull/1990)
 
+* Fixed System.Net.Http dependency declaration for net47 target framework to be a framework dependency instead of a nuget dependency - [#2122](https://github.com/fluentassertions/fluentassertions/pull/2122)
+
 ## 6.9.0
 
 ### What's new