New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly recognized non-class types as internal when using HaveAccessModifier assertion #1743
Conversation
…uld not be recognized as internal when using HaveAccessModifier.
Closes #1741 |
This is my first time contributing, and I'm not sure if the check list is something I should be filling out, or if that's in place for a maintainer to fill. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please give the PR itself also a functional description, for instance, by reusing part of the release notes? Because the title will appear in the auto-generated Github release note.
@@ -58,6 +58,36 @@ public void When_asserting_an_internal_type_is_internal_it_succeeds() | |||
act.Should().NotThrow(); | |||
} | |||
|
|||
[Fact] | |||
public void When_asserting_an_internal_member_is_internal_it_succeeds() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also test enums and structs.
You could modify
When_asserting_an_internal_type_is_internal_it_succeeds
and When_asserting_an_internal_type_is_protected_internal_it_throws
from a [Fact]
to a [Theory]
covering class
, interface
, enum
, struct
.
@jonathonchase are you planning to follow-up on @jnyrup's comments? |
Replaced by #1793 |
Removes
IsClass
check preventing enums and interfaces from being recognized as internal types when not nested.Fixes #1741
IMPORTANT
AcceptApiChanges.ps1
/AcceptApiChanges.sh
.