Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ContainItemsAssignableTo
Now Expects At Least One Item Assignable toT
#1765ContainItemsAssignableTo
Now Expects At Least One Item Assignable toT
#1765Changes from 2 commits
03aa90e
99cc1bc
4351910
f4f87ba
60a8890
3e72550
799d035
b0afd36
65a30b1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I think we need to avoid enumerating the collection twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, this implementation is almost identical to the existing
AllBeAssignableTo
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dennisdoomen the last changes in f4f87ba no longer enumerate the collection twice:
https://github.com/MullerWasHere/fluentassertions/blob/f4f87bad178ba8552c47743844ec0b35e61807af/Src/FluentAssertions/Collections/GenericCollectionAssertions.cs#L968-L976
@jnyrup Should I refactor both
AllBeAssignableTo
andContainItemsAssignableTo
to reduce duplication?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, they solve different problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still does. You first do an
Any()
and then anAny(predicate)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dennisdoomen I misunderstood that as a potential issue with
IEnumerable
s. Removedany()
and adjusted unit tests in 60a8890.