Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fill gaps in System.Data unit testing #1814

Merged
merged 6 commits into from Feb 21, 2022
Merged

Fill gaps in System.Data unit testing #1814

merged 6 commits into from Feb 21, 2022

Commits on Feb 21, 2022

  1. Corrected indentation in DataRowSpecs.cs and DataTableSpecs.cs.

    @logiclrd
    logiclrd committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    b75f362 View commit details
    Browse the repository at this point in the history

  2. Added missing unit tests to DataSetSpecs.cs, DataTableSpecs.cs and Da… 

    …taRowSpecs.cs.
    @logiclrd
    logiclrd committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    50984ac View commit details
    Browse the repository at this point in the history

  3. Renamed all of the tests in DataSetSpecs.cs, DataTableSpecs.cs and Da… 

    …taRowSpecs.cs to avoid specifying actual type and member names, and to be more explicit about what exactly is being tested.
    @logiclrd
    logiclrd committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    84a6967 View commit details
    Browse the repository at this point in the history

  4. Corrected a few places where tests had data whose relation to the tes… 

    …t subject was not obvious.

Corrected a few places where tests were assuming ambient data (such as that the ambient locale was not "fr-CA") that might not always be true.
    @logiclrd
    logiclrd committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    c526d40 View commit details
    Browse the repository at this point in the history

  5. Removed extraneous quotes from failure messages in System.Data assert… 

    …ions.

Updated assertions of exceptions in DataSetSpecs.cs, DataTableSpecs.cs and DataRowSpecs.cs to include exception message patterns to ensure that they are the _right_ exceptions.
    @logiclrd
    logiclrd committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    1b7ef07 View commit details
    Browse the repository at this point in the history

  6. Changed calls to .OfType on System.Data collections in equivalency st… 

    …eps and unit tests to use .Cast instead.
    @logiclrd
    logiclrd committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    5db93d5 View commit details
    Browse the repository at this point in the history