Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed netcoreapp2.0 framework check in formatting precision tests #1976

Merged
merged 3 commits into from Aug 31, 2022
Merged

Removed netcoreapp2.0 framework check in formatting precision tests #1976

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d68a6e6
Removed netcoreapp2.0 framework check in formatting precision tests
iliashkolyar Aug 20, 2022
b46d86b
Added fix note to releases.md
iliashkolyar Aug 20, 2022
db5bb0a
Revert "Added fix note to releases.md"
iliashkolyar Aug 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 2 additions & 10 deletions Tests/FluentAssertions.Specs/Formatting/FormatterSpecs.cs
View file
Open in desktop
Expand Up @@ -458,11 +458,7 @@ public void When_formatting_single_it_should_have_max_precision()
string result = Formatter.ToString(value);

// Assert
#if NETCOREAPP3_0_OR_GREATER
result.Should().Be("0.33333334F");
#else
result.Should().Be("0.333333343F");
#endif
result.Should().BeOneOf("0.33333334F", "0.333333343F");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel uncomfortable when we don't know exactly what the expectation is.
Maybe we can argue that it is not relevant for FluentAssertion itself.

}

[Fact]
Expand Down Expand Up @@ -555,11 +551,7 @@ public void When_formatting_double_it_should_have_max_precision()
string result = Formatter.ToString(value);

// Assert
#if NETCOREAPP3_0_OR_GREATER
result.Should().Be("0.3333333333333333");
#else
result.Should().Be("0.33333333333333331");
#endif
result.Should().BeOneOf("0.3333333333333333", "0.33333333333333331");
}

[Fact]
Expand Down