Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate target frameworks #1980

Merged
merged 1 commit into from Aug 29, 2022
Merged

Deduplicate target frameworks #1980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 17 additions & 6 deletions Tests/Approval.Tests/ApiApproval.cs
View file
Open in desktop
Expand Up @@ -5,6 +5,8 @@
using System.Runtime.CompilerServices;
using System.Text;
using System.Threading.Tasks;
using System.Xml.Linq;
using System.Xml.XPath;
using DiffPlex.DiffBuilder;
using DiffPlex.DiffBuilder.Model;
using PublicApiGenerator;
Expand All @@ -18,12 +20,7 @@ namespace Approval.Tests;
public class ApiApproval
{
[Theory]
[InlineData("net47")]
[InlineData("net6.0")]
[InlineData("netstandard2.0")]
[InlineData("netstandard2.1")]
[InlineData("netcoreapp2.1")]
[InlineData("netcoreapp3.0")]
[ClassData(typeof(TargetFrameworksTheoryData))]
public Task ApproveApi(string frameworkVersion)
{
string codeBase = Assembly.GetExecutingAssembly().Location;
Expand Down Expand Up @@ -75,4 +72,18 @@ public static Task<CompareResult> OnlyIncludeChanges(string received, string ver
var compareResult = CompareResult.NotEqual(builder.ToString());
return Task.FromResult(compareResult);
}

private class TargetFrameworksTheoryData : TheoryData<string>
{
public TargetFrameworksTheoryData()
{
var csproj = Path.Combine(GetSourceDirectory(), Path.Combine("..", "..", "Src", "FluentAssertions", "FluentAssertions.csproj"));
var project = XDocument.Load(csproj);
var targetFrameworks = project.XPathSelectElement("/Project/PropertyGroup/TargetFrameworks");
foreach (string targetFramework in targetFrameworks!.Value.Split(';'))
{
Add(targetFramework);
}
}
}
}