Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanups #1998

Merged
merged 8 commits into from Sep 14, 2022
Merged

Cleanups #1998

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
519dd41
Remove calls to ToArray
jnyrup Sep 11, 2022
2ce4d3b
Don't guard Remove with Contains
jnyrup Sep 11, 2022
eaf64e7
Formatting
jnyrup Sep 11, 2022
2074e17
Rename internal parameter to match interface declaration
jnyrup Sep 11, 2022
db7a99d
Avoid fetching method parameters twice
jnyrup Sep 11, 2022
02a1385
Simplify expression with pattern matching
jnyrup Sep 11, 2022
513b99f
Use using declaration
jnyrup Sep 11, 2022
1275c26
Remove unused using
jnyrup Sep 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions Src/FluentAssertions/Common/TypeExtensions.cs
View file
Open in desktop
Expand Up @@ -442,8 +442,8 @@ public static ConstructorInfo GetConstructor(this Type type, IEnumerable<Type> p
&& m.IsSpecialName
&& m.ReturnType == targetType
&& predicate(m.Name)
&& m.GetParameters().Length == 1
&& m.GetParameters()[0].ParameterType == sourceType);
&& m.GetParameters() is { Length: 1 } parameters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

&& parameters[0].ParameterType == sourceType);
}

public static bool IsAssignableToOpenGeneric(this Type type, Type definition)
Expand Down