New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs spellcheck via GitHub Actions #2017
Conversation
cSpell has 39 findings in 16 files. Should be a quick cleanup. |
@dennisdoomen FYI :) I think this is ready for review/merge at your leisure. I'll do a self-review now to leave comments. |
Thanks for the contribution. I would prefer to have the build steps encoded in the Nuke build script and rely as little as possible on the YAML madness. Would that something you would be willing to pick up? |
@dennisdoomen sorry but I really don't have space for that. Not familiar with Nuke and really only have the space to reproduce my templated changes. GitHub actions makes it pretty easy and I don't find YAML to be particularly hard at all. Let me know if I can explain any of the YAML. If Nuke can install node, and install cSpell, and run the cSpell cli, then this PR should provide a template for what packages to install and what to tell Nuke to do. 👍 Feel free to close if it's not what you're looking for, no offense will be taken. 😄 |
Nuke has |
No worries. I will take care of that when I have space myself ;-) |
Hi :) is this PR stale? Because if you don't mind (@dennisdoomen, @SeanKilleen) I can give this a try to convert to NUKE. |
@IT-VBFK You're very welcome to give it try ❤️ |
Cool Just a few questions:
|
No, but ideally, our build script runs locally just like it runs on the server. There's no .NET package to install Node and NPM, but in my projects, we got pretty close using Yarn:
|
Ok, but this requires to have node installed. Is it arguable to force contributors to install node on their dev devices only to run NUKE? Or just skip the Edit: What's my advantage here? Because of node.js have to be installed, I have to use the github action "Setup NodeJS" which also installs NPM. |
It will unpack a specific version of Node in a portable fashion so that nobody has to have the right version of Node installed locally or on the build server. |
Thanks for you help :) I think I have a reasonable state now :) |
No problem :) |
IMPORTANT