Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comparable type assertions referential equality #2046

Merged
merged 3 commits into from Nov 28, 2022
Merged

Comparable type assertions referential equality #2046

merged 3 commits into from Nov 28, 2022

Commits on Nov 28, 2022

  1. Use EquatableOfInt to test for equality

    @jnyrup
    jnyrup committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    236ee83 View commit details
    Browse the repository at this point in the history

  2. Cleanup

    @jnyrup
    jnyrup committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    4e9d5e9 View commit details
    Browse the repository at this point in the history

  3. Let SameInstanceIsNotEqualClass implement IComparable<T> 

    This ensures that tests using it use `ComparableTypeAssertions.Be` and not `ObjectAssertions.Be`.

`ComparableTypeAssertions.Be` has in all stable releases respected referential equality since its addition in b77dad2.

97efc67 released with 6.0.0-alpha1 did not respect referential equality.

2d865aa released with 6.0.0-beta1 again respected referential equality.
    @jnyrup
    jnyrup committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    f58c3f3 View commit details
    Browse the repository at this point in the history