Extend ThatArePublicOrInternal to also look at the setter of properties

Src/FluentAssertions/Types/PropertyInfoSelector.cs

@@ -40,16 +40,16 @@ public PropertyInfoSelector(IEnumerable<Type> types)
     }
 
     /// <summary>
-    /// Only select the properties that have a public or internal getter.
+    /// Only select the properties that have atleast one public or internal accessor
     /// </summary>
     public PropertyInfoSelector ThatArePublicOrInternal
     {
         get
         {
             selectedProperties = selectedProperties.Where(property =>
             {
-                MethodInfo getter = property.GetGetMethod(nonPublic: true);
-                return (getter is not null) && (getter.IsPublic || getter.IsAssembly);
+                return property.GetGetMethod(nonPublic: true) is { IsPublic: true } or { IsAssembly: true }
+                    || property.GetSetMethod(nonPublic: true) is { IsPublic: true } or { IsAssembly: true };
             });
 
             return this;

Tests/FluentAssertions.Specs/Types/PropertyInfoSelectorSpecs.cs

@@ -355,6 +355,45 @@ public void When_selecting_properties_return_types_it_should_return_the_correct_
                 , typeof(string), typeof(int), typeof(int), typeof(int), typeof(int)
             });
     }
+
+    [Fact]
+    public void When_selecting_properties_with_only_set_accessors_it_should_return_the_applicable_properties()
+    {
+        // Arrange
+        Type type = typeof(TestClassForPropertyInfoSelector);
+
+        // Act
+        IEnumerable<PropertyInfo> properties = type.Properties().ThatArePublicOrInternal.ToArray();
+
+        // Assert
+        properties.Should().HaveCount(3);
+    }
+
+    [Fact]
+    public void When_selecting_properties_with_different_accessors_from_an_abstract_class_should_return_the_applicable_properties()
+    {
+        // Arrange
+        Type type = typeof(TestClassForPropertySelector);
+
+        // Act
+        IEnumerable<PropertyInfo> properties = type.Properties().ThatArePublicOrInternal.ToArray();
+
+        // Assert
+        properties.Should().HaveCount(8);
+    }
+
+    [Fact]
+    public void When_selecting_properties_with_atleast_one_accessor_being_private_should_return_the_applicable_properties()
+    {
+        // Arrange
+        Type type = typeof(TestClassForPropertyInfoSelectorWithOnePrivateAccessor);
+
+        // Act
+        IEnumerable<PropertyInfo> properties = type.Properties().ThatArePublicOrInternal.ToArray();
+
+        // Assert
+        properties.Should().HaveCount(4);
+    }
 }
 
 #region Internal classes used in unit tests
@@ -456,4 +495,26 @@ public DummyPropertyAttribute(string value)
     public string Value { get; private set; }
 }
 
+public class TestClassForPropertyInfoSelector
+{
+    private static string myPrivateStaticStringField;
+
+    public static string PublicStaticStringProperty { set => myPrivateStaticStringField = value; }
+
+    public static string InternalStaticStringProperty { get; set; }
+
+    public int PublicIntProperty { get; init; }
+}
+
+public class TestClassForPropertyInfoSelectorWithOnePrivateAccessor
+{
+    public bool PublicBoolPrivateGet { private get; set; }
+
+    public bool PublicBoolPrivateSet { get; private set; }
+
+    internal bool InternalBoolPrivateGet { private get;  set; }
+
+    internal bool InternalBoolPrivateSet { get; private set; }
+}
+
 #endregion

docs/_pages/releases.md

@@ -20,6 +20,7 @@ sidebar:
 * Added new extension methods to be able to write `Exactly.Times(n)`, `AtLeast.Times(n)` and `AtMost.Times(n)` in a more fluent way - [#2047](https://github.com/fluentassertions/fluentassertions/pull/2047)
 
 ### Fixes
+* Fixed `ThatArePublicOrInternal` property of `PropertyInfoSelector` not including properties with set accessors - [#2084] (https://github.com/fluentassertions/fluentassertions/pull/2082)
 * Quering properties on classes, e.g. `typeof(MyClass).Properties()`, now also includes static properties - [#2054](https://github.com/fluentassertions/fluentassertions/pull/2054)
 * Nested AssertionScopes now print the inner scope reportables - [#2044](https://github.com/fluentassertions/fluentassertions/pull/2044)
 * Throw `ArgumentException` instead of `ArgumentNullException` when a required `string` argument is empty - [#2023](https://github.com/fluentassertions/fluentassertions/pull/2023)