Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Build.cs #2093

Merged
merged 16 commits into from Jan 14, 2023
+83 −69
Merged

Clean up Build.cs #2093

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
92633cc
Clean up `Build.cs`
IT-VBFK Jan 9, 2023
3249a00
Keep related code together as near as possible
IT-VBFK Jan 9, 2023
91f9ce2
Use `InvariantCultureIgnoreCase`
IT-VBFK Jan 10, 2023
3f8c298
Proceed pipeline on independent failure of targets
IT-VBFK Jan 11, 2023
dc1e257
Retire `BuildNumber`, `BranchSpec` and `PullReuqestBase`, inject `Git…
IT-VBFK Jan 11, 2023
537f01d
Use injected `IsPullRequest`
IT-VBFK Jan 11, 2023
ac4d615
Rename `ApiKey` to `NuGetApiKey`
IT-VBFK Jan 11, 2023
ddfe6b5
Add new `Informations` target
IT-VBFK Jan 11, 2023
6934a4e
Split `UnitTests` target into windows and unix
IT-VBFK Jan 11, 2023
e06b4a3
Remove obsolete `.Produces()` on `Pack` target
IT-VBFK Jan 12, 2023
c7b44f0
Mark nuget api key as `Secret`
IT-VBFK Jan 13, 2023
9c51476
Remove `Informations` target and revert the `.DependsOn()` thing
IT-VBFK Jan 13, 2023
1552f35
Merge branch 'clean-up-build-file' of github.com:IT-VBFK/fluentassert…
IT-VBFK Jan 13, 2023
89584ab
Simplify `UnitTestsNetFramework`
IT-VBFK Jan 13, 2023
faba091
Use type safe configurations
IT-VBFK Jan 13, 2023
a541516
Move `YarnCli` to original place
IT-VBFK Jan 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions Build/Build.cs
View file
Open in desktop
Expand Up @@ -115,7 +115,7 @@ class Build : NukeBuild
{
DotNetBuild(s => s
.SetProjectFile(Solution)
.SetConfiguration("CI")
IT-VBFK marked this conversation as resolved.
Show resolved Hide resolved
.SetConfiguration(Configuration.CI)
.EnableNoLogo()
.EnableNoRestore()
.SetAssemblyVersion(GitVersion.AssemblySemVer)
Expand All @@ -129,7 +129,7 @@ class Build : NukeBuild
.Executes(() =>
{
DotNetTest(s => s
.SetConfiguration("Release")
.SetConfiguration(Configuration.Release)
.SetProcessEnvironmentVariable("DOTNET_CLI_UI_LANGUAGE", "en-US")
.EnableNoBuild()
.CombineWith(
Expand Down Expand Up @@ -166,7 +166,7 @@ class Build : NukeBuild
.Executes(() =>
{
DotNetTest(s => s
.SetConfiguration("Debug")
.SetConfiguration(Configuration.Debug)
.SetProcessEnvironmentVariable("DOTNET_CLI_UI_LANGUAGE", "en-US")
.EnableNoBuild()
.SetDataCollector("XPlat Code Coverage")
Expand Down Expand Up @@ -229,7 +229,7 @@ class Build : NukeBuild
select new { project, framework };

DotNetTest(s => s
.SetConfiguration("Debug")
.SetConfiguration(Configuration.Debug)
.SetProcessEnvironmentVariable("DOTNET_CLI_UI_LANGUAGE", "en-US")
.EnableNoBuild()
.SetDataCollector("XPlat Code Coverage")
Expand Down Expand Up @@ -259,7 +259,7 @@ class Build : NukeBuild
DotNetPack(s => s
.SetProject(Solution.Core.FluentAssertions)
.SetOutputDirectory(ArtifactsDirectory)
.SetConfiguration("Release")
.SetConfiguration(Configuration.Release)
.EnableNoLogo()
.EnableNoRestore()
.EnableContinuousIntegrationBuild() // Necessary for deterministic builds
Expand Down
15 changes: 15 additions & 0 deletions Build/Configuration.cs
View file
Open in desktop
@@ -0,0 +1,15 @@
using System.ComponentModel;
using Nuke.Common.Tooling;

[TypeConverter(typeof(TypeConverter<Configuration>))]
public class Configuration : Enumeration
{
public static Configuration Debug = new Configuration { Value = nameof(Debug) };
public static Configuration Release = new Configuration { Value = nameof(Release) };
public static Configuration CI = new Configuration { Value = nameof(CI) };

public static implicit operator string(Configuration configuration)
{
return configuration.Value;
}
}