Run tests under .NET 8 #2466

vbreuss · 2023-11-15T09:57:37Z

Discussion in #2465

Enable tests to run under .NET 8.

IMPORTANT

If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
The code complies with the Coding Guidelines for C#.
The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
- Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

github-actions · 2023-11-15T10:03:26Z

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

Register at Qodana Cloud and configure the action
Use GitHub Code Scanning with Qodana
Host Qodana report at GitHub Pages
Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.8
        with:
          upload-result: true

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

coveralls · 2023-11-15T19:10:09Z

Pull Request Test Coverage Report for Build 6920937500

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

0 of 0 changed or added relevant lines in 0 files are covered.
7 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.02%) to 97.475%

Files with Coverage Reduction	New Missed Lines	%
Src/FluentAssertions/Formatting/FormattedObjectGraph.cs	1	91.15%
Src/FluentAssertions/AssertionExtensions.cs	3	95.45%
Src/FluentAssertions/CallerIdentifier.cs	3	92.06%

Totals
Change from base Build 6874777002:	0.02%
Covered Lines:	11741
Relevant Lines:	11925

💛 - Coveralls

dennisdoomen

We should update the documentation (index.html, releases.md, etc) to mention that we're compatible with .NET 8.0

IT-VBFK · 2023-11-17T18:48:56Z

docs/index.html

@@ -29,7 +29,7 @@
     [<i class="fa fa-coffee"></i> Buy us a coffee](https://ko-fi.com/dennisdoomen){: .btn .btn--paypal}
     <br/>
     A very extensive set of extension methods that allow you to more naturally specify the expected outcome of a TDD or
-     BDD-style unit tests. Targets .NET Framework 4.7, as well as .NET 6, .NET Standard 2.0 and 2.1.'
+     BDD-style unit tests. Targets .NET Framework 4.7, as well as .NET 6, .NET 8, .NET Standard 2.0 and 2.1.'


Should this be just a note that we are ".NET 8 ready", since we don't target .NET 8

Yes, something like that. Or we should rephrase all of the references to the frameworks. Like "Works with .NET Standard 2.0 and higher, .NET Framework 4.7 and higher and .NET 6 and higher"

I also think there are a couple of other places where we mention the version, including the NuGet description and such.

You were right. I found three more places 😄

…k 4.7 and higher and .NET 6 and higher.`

dennisdoomen · 2023-11-19T08:19:45Z

103 new problems were found

This is something of a challenge as well. All the issues reported might be existing ones that now get redetected through .NET 8 target. We may have to update the baseline or bump the limit.

… 2.0 and 2.1.` with `Works with .NET Standard 2.0 and higher, .NET Framework 4.7 and higher and .NET 6 and higher.`

vbreuss · 2023-11-19T08:52:20Z

103 new problems were found

This is something of a challenge as well. All the issues reported might be existing ones that now get redetected through .NET 8 target. We may have to update the baseline or bump the limit.

How would I do this?

Updating the baseline will have to be done by you, right?
Bumping the limit would mean, increasing the failThreshold from 19 to 122 in qodana.yaml?

vbreuss · 2023-11-19T11:44:48Z

103 new problems were found

I had a look at the mentioned issues in the Files changed-Tab and most of them seem to be incorrect🤷:

All issues are only for two files (AssertionExtensions.cs and CallerIdentifier.cs)
The issues list (nearly) all using statements as incorrect.
,
Also the cannot resolve reference in XML comment seem incorrect

jnyrup · 2023-11-19T11:57:08Z

According to https://youtrack.jetbrains.com/issue/QD-7660/Qodana-busted-in-.NET-8-RTM support for .NET 8 is not available yet, but will be with v233.
We're at QDNET-232.10203.29

IT-VBFK · 2023-11-19T13:11:15Z

@vbreuss Can you check what happens if you change args: --baseline,qodana.sarif.json,--ide,QDNET to args: --baseline,qodana.sarif.json,--ide,QDNET-EAP? Just to verify this fixes the issues...

…e,QDNET-EAP`

IT-VBFK · 2023-11-19T13:27:46Z

Cool.. seems work 😉

vbreuss · 2023-11-19T13:59:35Z

@vbreuss Can you check what happens if you change args: --baseline,qodana.sarif.json,--ide,QDNET to args: --baseline,qodana.sarif.json,--ide,QDNET-EAP? Just to verify this fixes the issues...

Yes, it works.
previously it was

now it is

Will now undo the test...

…,--ide,QDNET-EAP`

IT-VBFK · 2023-11-19T14:29:59Z

@vbreuss FYI You could just have dropped the commit 😉

IT-VBFK · 2023-11-19T17:00:47Z

wow.. the qodana scan after this PR on develop 🙈

dennisdoomen · 2023-11-19T20:42:27Z

@vbreuss can you please put back that -EAP argument?

vbreuss · 2023-11-19T20:52:06Z

@vbreuss can you please put back that -EAP argument?

Of course, see #2474

Enable .NET 8 for test projects

3586994

vbreuss force-pushed the topic/vb/enable-net8 branch 2 times, most recently from 5bda626 to 672c1af Compare November 15, 2023 18:50

Keep .NET 6 test target framework

af87301

vbreuss force-pushed the topic/vb/enable-net8 branch from 672c1af to af87301 Compare November 15, 2023 18:53

vbreuss marked this pull request as ready for review November 15, 2023 18:56

Add .NET 8 to build pipeline

ed25fce

vbreuss marked this pull request as draft November 15, 2023 19:02

vbreuss marked this pull request as ready for review November 15, 2023 19:14

jnyrup approved these changes Nov 17, 2023

View reviewed changes

dennisdoomen approved these changes Nov 17, 2023

View reviewed changes

dennisdoomen self-requested a review November 17, 2023 15:50

dennisdoomen requested changes Nov 17, 2023

View reviewed changes

Document support for .NET 8 in releases.md and index.html

d90a018

IT-VBFK reviewed Nov 17, 2023

View reviewed changes

Rephrase with `Works with .NET Standard 2.0 and higher, .NET Framewor…

5e59dd5

…k 4.7 and higher and .NET 6 and higher.`

Replace `Targets .NET Framework 4.7, as well as .NET 6, .NET Standard…

f78b583

… 2.0 and 2.1.` with `Works with .NET Standard 2.0 and higher, .NET Framework 4.7 and higher and .NET 6 and higher.`

Test alternative qodana arguments: `--baseline,qodana.sarif.json,--id…

405d132

…e,QDNET-EAP`

Undo test alternative qodana arguments: `--baseline,qodana.sarif.json…

4c05e4e

…,--ide,QDNET-EAP`

dennisdoomen approved these changes Nov 19, 2023

View reviewed changes

dennisdoomen merged commit 8b14324 into fluentassertions:develop Nov 19, 2023
5 checks passed

vbreuss deleted the topic/vb/enable-net8 branch November 19, 2023 20:52

ITaluone mentioned this pull request Nov 29, 2023

Update the required minimum VS version #2491

Merged

7 tasks

jnyrup added testing Testing of Fluent Assertion itself building Building and Infrastructure of Fluent Assertions labels Feb 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run tests under .NET 8 #2466

Run tests under .NET 8 #2466

vbreuss commented Nov 15, 2023

github-actions bot commented Nov 15, 2023 •

edited

coveralls commented Nov 15, 2023 •

edited

dennisdoomen left a comment

IT-VBFK Nov 17, 2023

dennisdoomen Nov 18, 2023

dennisdoomen Nov 19, 2023

vbreuss Nov 19, 2023

dennisdoomen commented Nov 19, 2023

vbreuss commented Nov 19, 2023

vbreuss commented Nov 19, 2023

jnyrup commented Nov 19, 2023

IT-VBFK commented Nov 19, 2023

IT-VBFK commented Nov 19, 2023

vbreuss commented Nov 19, 2023

IT-VBFK commented Nov 19, 2023

IT-VBFK commented Nov 19, 2023

dennisdoomen commented Nov 19, 2023

vbreuss commented Nov 19, 2023

Run tests under .NET 8 #2466

Run tests under .NET 8 #2466

Conversation

vbreuss commented Nov 15, 2023

IMPORTANT

github-actions bot commented Nov 15, 2023 • edited

Qodana for .NET

coveralls commented Nov 15, 2023 • edited

Pull Request Test Coverage Report for Build 6920937500

Warning: This coverage report may be inaccurate.

💛 - Coveralls

dennisdoomen left a comment

Choose a reason for hiding this comment

IT-VBFK Nov 17, 2023

Choose a reason for hiding this comment

dennisdoomen Nov 18, 2023

Choose a reason for hiding this comment

dennisdoomen Nov 19, 2023

Choose a reason for hiding this comment

vbreuss Nov 19, 2023

Choose a reason for hiding this comment

dennisdoomen commented Nov 19, 2023

vbreuss commented Nov 19, 2023

vbreuss commented Nov 19, 2023

jnyrup commented Nov 19, 2023

IT-VBFK commented Nov 19, 2023

IT-VBFK commented Nov 19, 2023

vbreuss commented Nov 19, 2023

IT-VBFK commented Nov 19, 2023

IT-VBFK commented Nov 19, 2023

dennisdoomen commented Nov 19, 2023

vbreuss commented Nov 19, 2023

github-actions bot commented Nov 15, 2023 •

edited

coveralls commented Nov 15, 2023 •

edited